Fix for R16B's removal of parameterized modules #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy OTP's paramaterized module parse-transform (https://github.com/erlang/pmod_transform) into the source tree; add compiler pragmas to files that require parameterized modules to use the parse-transform (sockjs_pmod_pt). The module implementing the parse-transform has been renamed, as per OTP's suggestion, to avoid name clashes.
|
Hi @tsutsu - thanks for the patch. I'll try and attend to this in the next week or so. |
Sorry, been rather busy but I will try and get to this soon. |
Closed
|
Is there any reason this is not merged yet? |
majek
added a commit
that referenced
this pull request
Jan 5, 2014
Fix for R16B's removal of parameterized modules
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy OTP's parameterized module parse-transform
(https://github.com/erlang/pmod_transform) into the source tree;
add compiler pragmas to files that require parameterized modules
to use the parse-transform (sockjs_pmod_pt).
The module implementing the parse-transform has been renamed, as
per OTP's suggestion, to avoid name clashes.
Fixes #43.